Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contribution part about editor definition #1893

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

svor
Copy link
Contributor

@svor svor commented Mar 5, 2024

What does this PR do?

Add a part about Adding a Che Editor to Che into CONTRIBUTE.md file

What issues does this PR fix or reference?

eclipse-che/che#22854

Copy link

github-actions bot commented Mar 5, 2024

Click here to review and test in web IDE: Contribute

CONTRIBUTE.md Outdated Show resolved Hide resolved
Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor changed the title chore: add contribution part about editor definition chore: update contribution part about editor definition Mar 6, 2024
@svor svor self-assigned this Mar 6, 2024
@svor
Copy link
Contributor Author

svor commented Mar 6, 2024

@azatsarynnyy @tolusha I'd like to have your review as well to check that all attributes described properly

CONTRIBUTE.md Outdated Show resolved Hide resolved
CONTRIBUTE.md Outdated Show resolved Hide resolved
svor added 2 commits March 6, 2024 17:56
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azatsarynnyy, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor
Copy link
Contributor Author

svor commented Mar 6, 2024

/retest

@svor svor merged commit 3e6db8c into main Mar 7, 2024
17 checks passed
@svor svor deleted the sv-update-contribute-file branch March 7, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants