Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Gateway integration post #57

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Add the Gateway integration post #57

merged 10 commits into from
Jul 8, 2024

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Jun 28, 2024 •
edited
Loading

@azatsarynnyy azatsarynnyy force-pushed the gateway branch 2 times, most recently from 0dab912 to a160348 Compare July 1, 2024 13:45
@azatsarynnyy azatsarynnyy marked this pull request as ready for review July 1, 2024 13:50
@azatsarynnyy
Add the Gateway integration post
3d12415 
Signed-off-by: Artem Zatsarynnyi <[email protected]>
vitaliy-guliy
vitaliy-guliy reviewed Jul 2, 2024
View reviewed changes
assets/img/.DS_Store Outdated Show resolved Hide resolved
dkwon17
dkwon17 reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I have a some suggestions

_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
@azatsarynnyy
Copy link
Member Author

Looks great, I have a some suggestions

Thanks, @dkwon17, for thoroughly reading the post's content, for your detailed review, and for suggesting all the edits!
Each of them is valuable and contributes a lot to the quality of the text.
I applied each of them.

ibuziuk
ibuziuk reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azatsarynnyy great article!
I have provided quite a few suggestions to make it even more awesome (mainly semantics / formatting). Please, review and apply if relevant

azatsarynnyy and others added 2 commits July 4, 2024 17:31
@azatsarynnyy
Copy link
Member Author

@azatsarynnyy great article! I have provided quite a few suggestions to make it even more awesome (mainly semantics / formatting). Please, review and apply if relevant

@ibuziuk I reviewed your suggestions - all of them look relevant to me. I applied everything.
Thank you Ilya for your contributions to this article! 👍
All of them together greatly improve the text.

ibuziuk
ibuziuk reviewed Jul 5, 2024
View reviewed changes
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
_posts/2024-07-08-idea-editor.adoc Outdated Show resolved Hide resolved
@ibuziuk ibuziuk merged commit d65f3a4 into main Jul 8, 2024
8 checks passed
@ibuziuk ibuziuk deleted the gateway branch July 8, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@vitaliy-guliy vitaliy-guliy vitaliy-guliy left review comments

@dkwon17 dkwon17 dkwon17 left review comments

@l0rd l0rd Awaiting requested review from l0rd l0rd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azatsarynnyy @ibuziuk @vitaliy-guliy @dkwon17