Add rule violations list endpoint #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-bielecki-bosch
requested review from
bs-ondem,
MarcelBochtler,
mnonnenmacher,
nnobelis,
oheger-bosch and
sschuberth
as code owners
kamil-bielecki-bosch
requested review from
Etsija and
mmurto
as code owners
mnonnenmacher
requested changes
Sep 24, 2024
kamil-bielecki-bosch
force-pushed
the
add_rule_violations_list_endpoint
branch
2 times, most recently
from
78cbd13
to
766d53a
Compare
kamil-bielecki-bosch
force-pushed
the
add_rule_violations_list_endpoint
branch
2 times, most recently
from
6960b95
to
4f2f7fa
Compare
kamil-bielecki-bosch
force-pushed
the
add_rule_violations_list_endpoint
branch
9 times, most recently
from
141934c
to
7551ecf
Compare
mnonnenmacher
requested changes
Oct 1, 2024
kamil-bielecki-bosch
force-pushed
the
add_rule_violations_list_endpoint
branch
from
7551ecf
to
9b80b99
Compare
added 4 commits
October 1, 2024 14:14
Signed-off-by: Kamil Bielecki <[email protected]>
Change RuleViolationDao to inherit from SortableTable to enable paging features. Signed-off-by: Kamil Bielecki <[email protected]>
Add service for rule violations results with companion objects. Signed-off-by: Kamil Bielecki <[email protected]>
Add API endpoint for rule violations list under
/runs/{run_id}/rule-violations.
Signed-off-by: Kamil Bielecki <[email protected]>
kamil-bielecki-bosch
force-pushed
the
add_rule_violations_list_endpoint
branch
from
9b80b99
to
4bb24da
Compare
mnonnenmacher
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.