don't allow passing of values that are look very similar to an existing option (WIP) #1423
Conversation
test/framework/options.py
Outdated
| common_args = [] | ||
|
|
||
| eb_go = parse_options(args=common_args + ['-r', 'f']) | ||
| self.assertFalse(eb_go.options.robot == 'f') |
There was a problem hiding this comment.
@stdweird: for same reason, this doesn't work... -r f should be rejected by generaloption because there's an option -f, but it's not
I checked a bit, and for some reason is_value_a_commandline_option is getting () as a value passed in, rather than f which would lead to the reject
any idea? --robot/-r is a store_or_None option, could that be the reason?
There was a problem hiding this comment.
can you add a test that is not store_or_none? just to make sure the vsc-base is up to date? (or is this with python setup.py test?)
There was a problem hiding this comment.
I should be testing f in eb_go.options.robot to actually make the test fail, but fine :-)
There was a problem hiding this comment.
@stdweird: reproduced this problem with a test case for vsc-base, see hpcugent/vsc-base#200
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2165/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2184/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
boegel
changed the title
|
blocked by hpcugent/vsc-base#200 |
|
@boegel relevance? |
fix for easybuilders/easybuild#113