Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkgdown site #698

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

phdjsep
Copy link

@phdjsep phdjsep commented Dec 23, 2024

Hello! Huge fan of duckdb and R. Wanted to make some small improvements to the pkgdown site and set the seeds for future vignette contributions.

I've done the following in this PR:

  • Added an index.md file to separate Github README presentation from pkgdown site
  • Moved pkgdown.yml to pkgdown/ folder; added description to the home page
  • Create a "Get Started" page; Copied from duckdb Documentation for now
  • Added a switchable (light/dark) parameter in the pkgdown yml
  • Added a hex logo

@krlmlr
Copy link
Collaborator

krlmlr commented Dec 24, 2024

Thanks. CI/CD is failing:

Perhaps the ‘VignetteBuilder’ information is missing from the DESCRIPTION file?

I also quite enjoy the current vignette-less state: with a vignette, R CMD build needs to temporarily install the package, and this takes a long time here. Can we achieve a similar result with pkgdown articles that are not recognized by R CMD build , or perhaps with just .github/README.md and README.Rmd ?

Does the hex logo need to be over 2000 pixels wide? Is there perhaps a smaller version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants