Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build Unite-Qt .dmg for Mac OS in Gitian #663

Merged
merged 4 commits into from
Feb 22, 2019

Conversation

cmihai
Copy link
Member

@cmihai cmihai commented Feb 21, 2019

This commit removes the .dmg package (which packages Unite-Qt for Mac OS) from Gitian and updates the tests accordingly.

As discussed in #28, we will be shipping a .tar.gz with united, but without unite-qt for Mac from now on.

This commit removes the .dmg package (which packages Unite-Qt for Mac OS)
from Gitian and updates the tests accordingly.

Signed-off-by: Mihai Ciumeica <[email protected]>
@cmihai cmihai added the build Build system label Feb 21, 2019
@cmihai cmihai self-assigned this Feb 21, 2019
@cmihai cmihai requested review from Ruteri and a team February 21, 2019 16:54
doc/man/Makefile.am Outdated Show resolved Hide resolved
Signed-off-by: Mihai Ciumeica <[email protected]>
doc/man/Makefile.am Outdated Show resolved Hide resolved
@scravy
Copy link
Member

scravy commented Feb 22, 2019

Actually, what is the problem with a DMG? After all that's just some fancy archive.

@cmihai
Copy link
Member Author

cmihai commented Feb 22, 2019

It packaged the Unite-Qt binary, and only that. Since we're getting rid of Qt, it was easier to get rid of the DMG as well, rather than untangle all the assumptions and dependencies on Qt and package the united in it.

On the user side, people are used to "install" applications on Mac by dragging them from the DMG image to the dock or application folder or whatever, then clicking on the icon to launch it. Since united and unite-cli are console applications, this approach doesn't really work here (but it might work for the Electron wallet, so I'll look into packaging it into a .dmg once it's all done and tested).

@scravy
Copy link
Member

scravy commented Feb 22, 2019

I see, makes sense.

I'm wondering whether it would make sense to explore the option of having a future bundle for macos which would just start unit-e, hanging around in the systray area, like dropbox or google drive, or docker do, with "start/stop" menu and maybe a third item which opens a sort of terminal which you can use to give commands to the node. Would surely be a nice thing to have :-) I think I would even use it!

As I've said elsewhere. A proper DMG with a drag-and-dropable app can be given with the electron wallet. Would it come bundled with a united by the way? And would it also be built using gitian?

Copy link
Member

@scravy scravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK – The less code in the build system, the less to be built when moving to CMake 🎉 – #61

@cmihai
Copy link
Member Author

cmihai commented Feb 22, 2019

A proper DMG with a drag-and-dropable app can be given with the electron wallet. Would it come bundled with a united by the way? And would it also be built using gitian?

Particl-desktop downloads their daemon on first launch, but there's nothing preventing us from shipping our own with the installer. And we want reproducible builds, so yes to Gitian (there's issue dtr-org/unit-e-desktop#51 for this).

@cmihai cmihai changed the title Do not build .dmg for Mac OS in Gitian Do not build Unite-Qt .dmg for Mac OS in Gitian Feb 22, 2019
Copy link

@castarco castarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d1f56b6

Copy link
Member

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d1f56b6
Build the mac archive. I've had to disable the Qt man, but that's to be fixed in another PR.

@cmihai cmihai merged commit 1bde3a9 into dtr-org:master Feb 22, 2019
@cmihai cmihai deleted the remove-dmg branch February 22, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants