This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Minimal diff version #416
Open
Minimal diff version #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* iamp-nil-check * fix fmt * showing SG for 100% no diff * make 100% diff for SG * upated elb with delay
…o minimal-diff-version
Right now i just handled description
dtan4
suggested changes
Apr 21, 2019
There was a problem hiding this comment.
Sorry for the late review 🙇 let me request the following changes:
- Please divide changes per resource.
- Please do not use
sleepin the code. I think there is no need to add sleep anywhere. - Please do not add unnecessary empty lines. Please check other code.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in following cases, minimal diffs cannot be achieved.