Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up utils #692

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Clean up utils #692

wants to merge 5 commits into from

Conversation

jesteria
Copy link
Member

@jesteria jesteria commented May 9, 2019

This is @thcrock's PR. He can do what he likes with it!

Copy link
Member Author

@jesteria jesteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like nice clean-up to me

import testing.postgresql


def test_save_experiment_and_get_hash():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear to me how much of this is being moved around – (all of it?) ­– versus new code; so, keep that in mind.

but, for one, any reason not to use the fixtures, e.g. db_engine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of it's being moved around. These mostly predate the fixtures, so they can be refactored but that wasn't the focus of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I figured 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants