Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows Default to return the right Result #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allows Default to return the right Result #475

wants to merge 1 commit into from

Conversation

elcuervo
Copy link

@elcuervo elcuervo commented Jul 24, 2024 •
edited
Loading

Fixes instances when a Default type runs #try with a failing value.

Closes #469

Types::Integer.default(1).try("a")
# => #<Dry::Types::Result::Failure input="a" error=#<Dry::Types::ConstraintError: "a" violates constraints (type?(Integer, "a") failed)>>

@elcuervo
Allows Default to return the right Result
1b6766b 
Fixes instances when a Default type runs `#try` with a failing value.

```ruby
Types::Integer.default(1).try("a")
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default causes try/1 to raise an ConstraintError exception rather than an Failure
1 participant
@elcuervo