487 live tests #491
Open
487 live tests #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
========================================
- Coverage 94.4% 94.1% -0.3%
========================================
Files 23 23
Lines 1776 1788 +12
========================================
+ Hits 1678 1684 +6
- Misses 98 104 +6
|
M0dEx
reviewed
Dec 1, 2024
Comment on lines
+8
to
+11
| try: | ||
| from typing import cast | ||
| except ImportError: | ||
| from typing_extensions import cast |
There was a problem hiding this comment.
Wouldn't from typing_extensions import cast suffice, as it already does a very similar thing under the hood?
Comment on lines
+214
to
+217
| return self._check_hns_root_metadata(cloud_path) | ||
| except HttpResponseError as error: | ||
| if error.status_code == HTTPStatus.FORBIDDEN: | ||
| self._check_hns_root_metadata(cloud_path) |
There was a problem hiding this comment.
nit: to be consistent, either both of these should be a return statement or none of them should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live tests for #487