Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Added support for exporting SQL as OracleDB SQL #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kingpin98k
Copy link

Oracle Database SQL Export Functionality in DrawDB

Summary of Current Implementation

Export to Oracle SQL Files:

Successfully implemented the feature to convert database schemas into Oracle Database compatible SQL files.

welcomeTab
image

Import Functionality:

Currently under evaluation for feasibility and development planning.

Request for Guidance

  • Merge Approval: Requesting permission to merge the export feature into the main repository.

  • Next Steps: Seeking direction on whether to proceed with the import functionality or prioritize other tasks.

I am eager to align this project with our overall objectives and user needs. Please provide feedback and any specific considerations for the next steps.

Copy link

vercel bot commented Jul 30, 2024

@Kingpin98k is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@1ilit
Copy link
Member

1ilit commented Jul 30, 2024

Cool stuff man! I'm really excited about this

@Kingpin98k
Copy link
Author

Cool stuff man! I'm really excited about this

Thanks brother 🙂, tell me if any changes needs to be done.

@1ilit
Copy link
Member

1ilit commented Aug 3, 2024

Hey! This is great and really would love to merge but here's my dilemma. I don't think we can claim that oracle is fully supported because the import will be missing for a while. I don't know if we should disable import for oracle and have it incomplete or support is as another export option only for generic diagrams.

@Kingpin98k
Copy link
Author

Yeah I am kinda busy for now but will sure work on the import also, so till then you can leave it be and merge the feature once import is done 🙂👍

case "DATETIME":
oracleType = field.type;
break;
case "BOOLEAN":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle Database 23ai does support the BOOLEAN data type.

}
}

if (field.type === "ENUM" || field.type === "SET") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle Database 23ai does support ENUMs via Domains, see: https://stackoverflow.com/a/78453455/3860389

@gvenzl
Copy link

gvenzl commented Aug 21, 2024

Hey @Kingpin98k, this is amazing!

Thanks a lot for doing this PR, I'm really excited about it!
Please feel free to reach out to me if I can be of any help!

@Kingpin98k
Copy link
Author

Hey @Kingpin98k, this is amazing!

Thanks a lot for doing this PR, I'm really excited about it! Please feel free to reach out to me if I can be of any help!

Hey @gvenzl thanks for the insights, I will make sure to incorporate these changes in my next PR and will definitely reach out to you if I need any assistance.

@1ilit 1ilit force-pushed the main branch 2 times, most recently from 0ca7470 to d389c28 Compare November 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants