-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Added support for exporting SQL as OracleDB SQL #192
base: main
Are you sure you want to change the base?
Conversation
@Kingpin98k is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Cool stuff man! I'm really excited about this |
Thanks brother 🙂, tell me if any changes needs to be done. |
Hey! This is great and really would love to merge but here's my dilemma. I don't think we can claim that oracle is fully supported because the import will be missing for a while. I don't know if we should disable import for oracle and have it incomplete or support is as another export option only for generic diagrams. |
Yeah I am kinda busy for now but will sure work on the import also, so till then you can leave it be and merge the feature once import is done 🙂👍 |
case "DATETIME": | ||
oracleType = field.type; | ||
break; | ||
case "BOOLEAN": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oracle Database 23ai does support the BOOLEAN
data type.
} | ||
} | ||
|
||
if (field.type === "ENUM" || field.type === "SET") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oracle Database 23ai does support ENUMs via Domains, see: https://stackoverflow.com/a/78453455/3860389
Hey @Kingpin98k, this is amazing! Thanks a lot for doing this PR, I'm really excited about it! |
Hey @gvenzl thanks for the insights, I will make sure to incorporate these changes in my next PR and will definitely reach out to you if I need any assistance. |
0ca7470
to
d389c28
Compare
Oracle Database SQL Export Functionality in DrawDB
Summary of Current Implementation
Request for Guidance
Merge Approval: Requesting permission to merge the export feature into the main repository.
Next Steps: Seeking direction on whether to proceed with the import functionality or prioritize other tasks.
I am eager to align this project with our overall objectives and user needs. Please provide feedback and any specific considerations for the next steps.