Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unitest for oss #647

Merged
merged 1 commit into from
Aug 26, 2024
Merged

test: add unitest for oss #647

merged 1 commit into from
Aug 26, 2024

Conversation

Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Aug 5, 2024

Add some basic unitest for oss in object storage

Description

This PR is done by finishing the following tasks:

  • bump opendal version to 0.48.0
  • change mock framework from httpmock to wiremock
    • httpmock does not support specify the port, but unitest need to.
  • add unitest for ParsedURL and ObjectStorage
  • adn unitest for OSS part of ObjectStorage

More details are shown in the code

Related Issue

#496
#399

Motivation and Context

Dragonfly rust client does not support back-to-source downloading of different object storage protocols. Priority is given to supporting OSS protocol back-to-source downloads. Need to support OSS protocol in dragonfly-client-backend crate, implemented based on trait Backend and it needs to support directory recursive downloading.

@Lzzzzzt Lzzzzzt requested a review from a team as a code owner August 5, 2024 07:01
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 92.21557% with 13 lines in your changes missing coverage. Please review.

Project coverage is 13.82%. Comparing base (adc2bd6) to head (b23e8e4).
Report is 1 commits behind head on main.

Files Patch % Lines
dragonfly-client-backend/src/object_storage.rs 90.22% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   12.18%   13.82%   +1.63%     
==========================================
  Files          55       55              
  Lines       10971    11098     +127     
==========================================
+ Hits         1337     1534     +197     
+ Misses       9634     9564      -70     
Files Coverage Δ
dragonfly-client-backend/src/http.rs 92.15% <100.00%> (+0.40%) ⬆️
dragonfly-client-backend/src/lib.rs 80.86% <ø> (ø)
dragonfly-client-backend/src/object_storage.rs 37.40% <90.22%> (+36.63%) ⬆️

dragonfly-client-backend/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 8f3e5f3 into dragonflyoss:main Aug 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants