Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Ensure proper ref count of underlying ocx #12287

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 8, 2024

Backport of #12281 to release/9.0

/cc @lonitra

Customer Impact

Upon doing improvements to our interop code, we had missed releasing a pointer to the underlying ocx of the AxHost control, which was causing the underlying ocx to linger even after customer AxHost control is disposed. This causes the destructor of the of the underlying ocx to not get called because it still has a ref count of 1, causing issues with resource management in their application.

Testing

Tested manually with customer repro scenario and added regression test for the scenario.

Risk

Low. Change involves releasing the pointer we missed, correcting the ref count.

Microsoft Reviewers: Open in CodeFlow

@github-actions github-actions bot requested a review from a team as a code owner October 8, 2024 17:34
@lonitra lonitra added the Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.81152%. Comparing base (40bc98a) to head (2479868).
Report is 2 commits behind head on release/9.0.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/9.0      #12287         +/-   ##
=====================================================
- Coverage     74.81381%   74.81152%   -0.00230%     
=====================================================
  Files             3022        3022                 
  Lines           630147      630157         +10     
  Branches         46787       46787                 
=====================================================
- Hits            471437      471430          -7     
- Misses          155328      155337          +9     
- Partials          3382        3390          +8     
Flag Coverage Δ
Debug 74.81152% <71.42857%> (-0.00230%) ⬇️
integration 18.02693% <0.00000%> (-0.00402%) ⬇️
production 47.82223% <33.33333%> (-0.00563%) ⬇️
test 97.00766% <100.00000%> (+0.00007%) ⬆️
unit 44.85537% <33.33333%> (-0.00207%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra added Servicing-approved .NET Shiproom approved the PR for merge and removed Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Oct 8, 2024
@lonitra lonitra merged commit a9b2399 into release/9.0 Oct 8, 2024
8 checks passed
@lonitra lonitra deleted the backport/pr-12281-to-release/9.0 branch October 8, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants