Fix IDE0002 in LogTests.cs #12265
Merged
Fix IDE0002 in LogTests.cs #12265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul1956
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12265 +/- ##
===================================================
+ Coverage 75.43567% 75.43737% +0.00169%
===================================================
Files 3103 3103
Lines 634314 634301 -13
Branches 46876 46875 -1
===================================================
+ Hits 478499 478500 +1
+ Misses 152390 152377 -13
+ Partials 3425 3424 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonitra
changed the title
paul1956
added a commit
to paul1956/winforms
that referenced
this pull request
Oct 4, 2024
Fix IDE0002 in LogTests.cs
lonitra
added a commit
that referenced
this pull request
Oct 11, 2024
…ifying PR #11863 (#12261) * No code Chnages just formatting * Add tests for SignleInstanceHelper from #11863 * Moved to SDK RC2 (#12254) * Moved to SDK RC2 to get the same build errors in VS and CLI build and be able to fix them. Before this change the IntPreview version of VS was correctly complaining about a redundant cast(IDE0004) in ToolStrip.cs g.DrawLines(SystemPens.ControlText, (ReadOnlySpan<Point>) [ new(verticalBeamStart, _lastInsertionMarkRect.Y), new(verticalBeamStart, _lastInsertionMarkRect.Bottom - 1), new(verticalBeamStart + 1, _lastInsertionMarkRect.Y), new(verticalBeamStart + 1, _lastInsertionMarkRect.Bottom - 1) ]); But the CLI build required this cast. After the upgrade to RC2, IDE0300 - Collection initialization can be simplified - became more robust and required code fixes that use collection expressions applied to the solution. * Adds XML Comments to FileSystemProxy and SpecialDirectoriesProxy (#12141) * Add XML Comments related to FileSystemProxy which includes SpecialDirectoriesProxy * Fix some types * Add some language keywords * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * PR feedback * Update all XML comments * Fix Typo in FileSystemProxy that caused build to fail. * Update XML Coments * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb Co-authored-by: Tanya Solyanik <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb Co-authored-by: Tanya Solyanik <[email protected]> * Redo all the comments in SpecialDirectoriesProxy * Add cref per PR feedback and changed type to Namespace * PR Feedback to add see cref's --------- Co-authored-by: Loni Tra <[email protected]> Co-authored-by: Tanya Solyanik <[email protected]> * [main] Update dependencies from dotnet/runtime (#12266) [main] Update dependencies from dotnet/runtime * Fix IDE0002 in LogTests.cs (#12265) Fix IDE0002 in LogTests.cs * [main] Update dependencies from dotnet/arcade (#12271) [main] Update dependencies from dotnet/arcade * [main] Update dependencies from dotnet/runtime (#12272) [main] Update dependencies from dotnet/runtime * Improve code coverage for FileLogTraceListener from simplifying PR #11863 (#12264) * Improve code coverage for FileLogTraceListener * Update src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/FileLogTraceListenerTests.cs Thanks I had no idea about boolData Co-authored-by: Loni Tra <[email protected]> --------- Co-authored-by: Loni Tra <[email protected]> * Switch default feed to use wildcards only (#12268) * Switch default feed to full wildcard * Add other wildcards back * Move local closer to usage * PR Feedback * Address PR Feedback * PR Feedback * PR Feedback inline private Sub, reuse commandLine --------- Co-authored-by: Tanya Solyanik <[email protected]> Co-authored-by: Loni Tra <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rich Lander <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IDE0002 in LogTests.cs
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow