Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage for ToolStripSplitButton #12238

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Add code coverage for ToolStripSplitButton #12238

merged 5 commits into from
Oct 11, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Sep 27, 2024 •
edited by dotnet-policy-service bot
Loading

related #10453

Proposed changes
Add unit tests for ToolStripSplitButton.cs to test its properties & methods & events

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner September 27, 2024 02:01
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46470%. Comparing base (0d0e1c9) to head (5860bbb).
Report is 44 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12238         +/-   ##
===================================================
+ Coverage   75.42712%   75.46470%   +0.03757%     
===================================================
  Files           3102        3105          +3     
  Lines         634244      634551        +307     
  Branches       46866       46889         +23     
===================================================
+ Hits          478392      478862        +470     
+ Misses        152434      152264        -170     
- Partials        3418        3425          +7
Flag Coverage Δ
Debug 75.46470% <100.00000%> (+0.03757%) ⬆️
integration 17.97708% <ø> (-0.00250%) ⬇️
production 48.86426% <ø> (+0.06056%) ⬆️
test 97.02708% <100.00000%> (+0.00083%) ⬆️
unit 45.87257% <ø> (+0.03670%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Sep 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the 📭 waiting-author-feedback The team requires more information from the author label Sep 27, 2024
ricardobossan

This comment was marked as duplicate.

Sign in to view

@ricardobossan ricardobossan removed the waiting-review This item is waiting on review by one or more members of team label Sep 27, 2024
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed 📭 waiting-author-feedback The team requires more information from the author labels Sep 29, 2024
@LeafShi1 LeafShi1 mentioned this pull request Sep 29, 2024
Open
3 tasks
@Epica3055 Epica3055 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 29, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 30, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Sep 30, 2024
LeafShi1
LeafShi1 reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a little question

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripSplitButtonTests.cs Show resolved Hide resolved
@Tanya-Solyanik Tanya-Solyanik added 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Oct 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 8, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Oct 8, 2024
lonitra
lonitra approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Oct 8, 2024
@Tanya-Solyanik
Copy link
Member

@LeafShi1 - please re-review

@lonitra lonitra removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 10, 2024
@lonitra lonitra requested a review from LeafShi1 October 10, 2024 16:43
@LeafShi1 LeafShi1 merged commit c8d18e0 into dotnet:main Oct 11, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 11, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripSplitButton branch October 11, 2024 01:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

@ricardobossan ricardobossan ricardobossan left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@LeafShi1 LeafShi1 LeafShi1 approved these changes

@lonitra lonitra lonitra approved these changes

Assignees

@Zheng-Li01 Zheng-Li01

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
6 participants
@Zheng-Li01 @Tanya-Solyanik @lonitra @ricardobossan @LeafShi1 @Epica3055