Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for ImageListDesigner #11725

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Jul 22, 2024

Related #10773

Proposed changes

  • Add unit test ImageListDesignerTests.cs for public properties and method of the ImageListDesigner
  1. ActionLists
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74161%. Comparing base (fa07c1b) to head (5e01dea).
Report is 41 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11725         +/-   ##
======================================================
+ Coverage      74.55969%   74.74161%   +0.18191%     
======================================================
  Files              3041        3046          +5     
  Lines            629780      630646        +866     
  Branches          46845       46862         +17     
======================================================
+ Hits             469562      471355       +1793     
+ Misses           156849      155933        -916     
+ Partials           3369        3358         -11     
Flag Coverage Δ
Debug 74.74161% <100.00000%> (+0.18191%) ⬆️
integration 17.96325% <ø> (+0.09049%) ⬆️
production 47.76916% <ø> (+0.32242%) ⬆️
test 96.98541% <100.00000%> (+0.00715%) ⬆️
unit 44.81119% <ø> (+0.23873%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jul 22, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 22, 2024
@lonitra lonitra changed the base branch from main to feature/10.0 July 23, 2024 00:51
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 23, 2024
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jul 23, 2024
@John-Qiao John-Qiao force-pushed the Add-unit-tests-for-ImageListDesigner branch from 8971a0b to 5e01dea Compare July 23, 2024 10:12
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jul 23, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 68ea9d1 into dotnet:feature/10.0 Jul 23, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants