-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for ButtonBaseDesigner #11690
Merged
Tanya-Solyanik
merged 4 commits into
dotnet:feature/10.0
from
LeafShi1:Add_tests_for_ButtonBaseDesigner
Jul 23, 2024
Merged
Add unit tests for ButtonBaseDesigner #11690
Tanya-Solyanik
merged 4 commits into
dotnet:feature/10.0
from
LeafShi1:Add_tests_for_ButtonBaseDesigner
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeafShi1
force-pushed
the
Add_tests_for_ButtonBaseDesigner
branch
from
July 17, 2024 08:32
ec50268
to
12a5a1c
Compare
LeafShi1
force-pushed
the
Add_tests_for_ButtonBaseDesigner
branch
from
July 17, 2024 08:35
12a5a1c
to
a3648d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/10.0 #11690 +/- ##
======================================================
+ Coverage 74.55969% 74.73683% +0.17713%
======================================================
Files 3041 3046 +5
Lines 629780 630665 +885
Branches 46845 46862 +17
======================================================
+ Hits 469562 471339 +1777
+ Misses 156849 155955 -894
- Partials 3369 3371 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms.Design/tests/UnitTests/ButtonBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 17, 2024
src/System.Windows.Forms.Design/tests/UnitTests/ButtonBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 18, 2024
elachlan
added
the
waiting-review
This item is waiting on review by one or more members of team
label
Jul 18, 2024
SimonZhao888
previously approved these changes
Jul 19, 2024
lonitra
reviewed
Jul 19, 2024
src/System.Windows.Forms.Design/tests/UnitTests/ButtonBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
📭 waiting-author-feedback
The team requires more information from the author
and removed
waiting-review
This item is waiting on review by one or more members of team
labels
Jul 19, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
src/System.Windows.Forms.Design/tests/UnitTests/ButtonBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/tests/UnitTests/ButtonBaseDesignerTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/tests/UnitTests/ButtonBaseDesignerTests.cs
Show resolved
Hide resolved
Tanya-Solyanik
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 22, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 23, 2024
Tanya-Solyanik
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
ButtonBaseDesignerTests.cs
for public properties and method of the ButtonBaseDesignerMicrosoft Reviewers: Open in CodeFlow