-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Avoid unnecessary relinking when publishing a blazor project for AOT #82748
Merged
Commits on Mar 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b7e9946 - Browse repository at this point
Copy the full SHA b7e9946View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc38bb - Browse repository at this point
Copy the full SHA fcc38bbView commit details -
[wasm] Wasm.Build.Tests: Use $(_IsPublishing) to avoid unncessary
.. relinking during "Build", when publishing. `Publish` target triggers `Build` target to run. When publishing, we don't want to run relinking step during the `Build`, as it will be run for `Publish` anyway. Earlier there wasn't a good way to differentiate the two cases of `build` when building, and `build` when publishing, but now the sdk sets `$(_IsPublishing)=true`, which can be used here.
Configuration menu - View commit details
-
Copy full SHA for 4be35a7 - Browse repository at this point
Copy the full SHA 4be35a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 306eb03 - Browse repository at this point
Copy the full SHA 306eb03View commit details -
Wasm.Build.Tests: Add support for running published blazor projects
`dotnet run` uses the regular build output. Published blazor app, like when using AOT, needs to be run more "manually" by starting a web server in the publish folder. This is accomplished here by using the new xharness command `wasm webserver`.
Configuration menu - View commit details
-
Copy full SHA for 8950797 - Browse repository at this point
Copy the full SHA 8950797View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5c4c0d - Browse repository at this point
Copy the full SHA e5c4c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e7c968 - Browse repository at this point
Copy the full SHA 5e7c968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09052b6 - Browse repository at this point
Copy the full SHA 09052b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17a8255 - Browse repository at this point
Copy the full SHA 17a8255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ff3c1c - Browse repository at this point
Copy the full SHA 5ff3c1cView commit details
Commits on Mar 2, 2023
-
Updating 'Microsoft.DotNet.XHarness.CLI': '1.0.0-prerelease.23117.1' => '1.0.0-prerelease.23151.1' (from build '20230301.1' of 'https://github.com/dotnet/xharness') Updating 'Microsoft.DotNet.XHarness.TestRunners.Common': '1.0.0-prerelease.23117.1' => '1.0.0-prerelease.23151.1' (from build '20230301.1' of 'https://github.com/dotnet/xharness') Updating 'Microsoft.DotNet.XHarness.TestRunners.Xunit': '1.0.0-prerelease.23117.1' => '1.0.0-prerelease.23151.1' (from build '20230301.1' of 'https://github.com/dotnet/xharness')
Configuration menu - View commit details
-
Copy full SHA for 2ba2ac7 - Browse repository at this point
Copy the full SHA 2ba2ac7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.