Fix for unable to select a tab after backing out of a page and returning. #25011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected property of the CurrentPage.
…opertyChanged for IsSelected.
…into fix-24741
|
Hey there @BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The issue was due the IsSelected property of the NavigationView Item is not updated properly after navigating back from the page.
Description of Issue Fix
The fix involves resetting the IsSelected property for all NavigationView items in the Disconnect Handler, mapping the IsSelected property of the CurrentPage, and updating the IsSelected property of the NavigationViewItem by using OnPropertyChanged, similarly updating the Background when the IsSelected value is changed.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #24741
Output
24741-BeforeFix.mp4
24741-AfterFix.mp4