Fixed Shell Tab is still visible after set Tab.IsVisible to false #24999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
StephaneDelcroix
requested changes
Oct 3, 2024
| if (renderer?.ViewController != SelectedViewController) | ||
|
|
||
| if (renderer is null) | ||
| return; |
There was a problem hiding this comment.
this is returning too soon. CurrentRenderer isn't updated
| @@ -432,7 +432,7 @@ void OnCurrentShellSectionPropertyChanged(object? sender, System.ComponentModel. | |||
| if (_mainLevelTabs == null) | |||
| return; | |||
|
|
|||
| var currentItem = VirtualView.CurrentItem.CurrentItem; | |||
| var currentItem = VirtualView.CurrentItem?.CurrentItem; | |||
There was a problem hiding this comment.
did we enable nullable here ?
| @@ -270,7 +270,7 @@ void OnVisibleChildRemoved(Element child) | |||
| if (CurrentItem == child) | |||
| { | |||
| if (ShellItemController.GetItems().Count == 0) | |||
| ClearValue(CurrentItemProperty, specificity: SetterSpecificity.FromHandler); | |||
| ClearValue(CurrentItemProperty); | |||
There was a problem hiding this comment.
what's the rationale for dropping the specificity ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the visibility of the TabItem is changed dynamically, TabBar needs to be updated to reflect the TabBar items count, but hiding the visible TabItem updates the TabContent but doesn't automatically adjust the tab count.
Issues Fixed
Each time the DisplayedPage is modified,we have updated the TabBar items count through setupmenu().
Validated the behaviour in the following platforms
Fixes #8788
Fixes #23717
Fixes #23780
Before
Shell_before_fix.mp4
After
Shell_After_fix.mp4