Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable SAST scanning with CodeQL #197

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 28, 2023

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@crazy-max crazy-max marked this pull request as ready for review October 30, 2023 08:53
push:
branches:
- 'main'
pull_request:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not adding it for PRs too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull_request: means it will be triggered for any PRs against any based branch if you don't specify branches field under.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right!

Copy link

@gabriellavengeo gabriellavengeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

push:
branches:
- 'main'
pull_request:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right!

@crazy-max crazy-max merged commit b525cd9 into docker:main Oct 30, 2023
19 checks passed
@crazy-max crazy-max deleted the ci-codeql branch October 30, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants