Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase stable onto master #16963

Closed
wants to merge 15 commits into from

Conversation

thewilsonator
Copy link
Contributor

No description provided.

rikkimax and others added 15 commits October 7, 2024 13:43
Reverting dlang#14844, which caused such missing TypeInfos, *and* making
sure the special TypeInfo members are fully analyzed and ready for
codegen (otherwise hitting an assertion for the real-world project).
Required for 32-bit ARM, and non-Apple 64-bit ARM targets.

The only difference to `Gcc_Clang` is that anonymous and 0-length
bit-fields do contribute to the aggregate alignment.

Caught by existing proper C interop tests in
runnable_cxx/testbitfields.d on such targets. The hardcoded bad tests
in runnable/{bitfieldsposix64.c,dbitfieldsposix64.d} however now fail
after the fix, on such targets again.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24337 critical Segfault when printing an int[] cast from a string literal
24431 regression dmd -vcg-ast crashes printing failed template instantiation
24599 regression [REG2.103] Wrongly elided TypeInfo emission leading to undefined symbols at link-time
24687 regression [REG2.110] Cannot cast string-imports to select overload anymore
24699 regression [REG2.108] No short-circuit evaluation of mixing template bool argument
24731 normal IFTI cannot handle integer expressions
24760 normal ICE on variadic after default argument
24764 normal ICE when -vcg-ast prints imported invariant
24790 normal -vcg-ast ICE on lowered assign exp

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16963"

@thewilsonator thewilsonator deleted the rebase-stable2 branch October 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants