Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor longdouble.d #16680

Merged
merged 3 commits into from
Jul 12, 2024
Merged

refactor longdouble.d #16680

merged 3 commits into from
Jul 12, 2024

Conversation

0-v-0
Copy link
Contributor

@0-v-0 0-v-0 commented Jul 11, 2024

  1. Line 184: use static if when possible
  2. use enum instead of function to simplify code and avoid emitting to binary
  3. reduce duplicative static if
  4. fix typo

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @0-v-0! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16680"

@dkorpel dkorpel added the Refactoring No semantic changes to code label Jul 11, 2024
@dkorpel dkorpel merged commit dec236d into dlang:master Jul 12, 2024
41 checks passed
@0-v-0 0-v-0 deleted the refactor branch July 12, 2024 15:22
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request Oct 7, 2024
* refactor longdouble.d

* reduce duplicative code

* fix error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants