Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler/test/unit/semantic/imports.d: call deinitializeDMD #16568

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

the-horo
Copy link
Contributor

@the-horo the-horo commented Jun 8, 2024

There is the unit/deinitialization.d test that checks that variables are empty before calling initDMD. If this test happens to be run right before that one then the latter will fail.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16568"

There is the unit/deinitialization.d test that checks that variables
are empty before calling `initDMD`. If this test happens to be run
right before that one then the latter will fail.

Signed-off-by: Andrei Horodniceanu <[email protected]>
@dlang-bot dlang-bot merged commit a903c10 into dlang:master Jun 8, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants