POC: automatically move scope array literals to the stack

dlang · Sep 27, 2024 · 22c1a56 · 22c1a56
1 parent 1d0b93b
commit 22c1a56
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/compiler/src/dmd/semantic3.d b/compiler/src/dmd/semantic3.d
@@ -1310,6 +1310,26 @@ private extern(C++) final class Semantic3Visitor : Visitor
 
         finishScopeParamInference(funcdecl, f);
 
+        {
+            // Promote array literals like `auto x = [y];` to stack if possible
+            import dmd.foreachvar;
+            void dgVar(VarDeclaration v)
+            {
+                if (v.maybeScope && v._init)
+                    if (auto ei = v._init.isExpInitializer())
+                        if (auto ce = ei.exp.isConstructExp())
+                            if (auto ale = ce.e2.isArrayLiteralExp())
+                                ale.onstack = true;
+            }
+
+            void dgExp(Expression e)
+            {
+                foreachVar(e, &dgVar);
+            }
+
+            foreachExpAndVar(funcdecl.fbody, &dgExp, &dgVar);
+        }
+
         // reset deco to apply inference result to mangled name
         if (f != funcdecl.type)
             f.deco = null;

diff --git a/compiler/test/runnable/betterc.d b/compiler/test/runnable/betterc.d
@@ -43,6 +43,7 @@ extern (C) void main()
     testRuntimeLowerings();
     test18457();
     test20737();
+    testScopeInferenceArrayLiteral();
 }
 
 /*******************************************/
@@ -221,3 +222,15 @@ void test22427()
     char[] p;
     auto a = cast(int[])p;
 }
+
+/*******************************************/
+// Test that local variable can be inferred scope, moving
+// array literal from GC to stack, allowing usage in betterC
+
+int testScopeInferenceArrayLiteral()
+{
+    auto x = [10, 20, 30] ~ [40];
+    x[0] = 50;
+    assert(x[0] + x[1] == 70);
+    return x[0];
+}