Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mkmf-lite a runtime dependency #75

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Make mkmf-lite a runtime dependency #75

merged 1 commit into from
Sep 30, 2024

Conversation

Lqp1
Copy link
Contributor

@Lqp1 Lqp1 commented Sep 30, 2024

Make mkmf-lite a runtime dependency

Since 305b6b7 the gem is used at runtime too.

FIXES: #74

@djberg96
Copy link
Owner

Oops, forgot to change that. I did bump the version, though, so you'll want to rebase and bump it to 0.7.

@Lqp1
Copy link
Contributor Author

Lqp1 commented Sep 30, 2024

Hello @djberg96 ,

Thanks for checking :)

Please tell me if I misunderstood something but it seems you refer to 00c6931 which is not on main, only on the dedicated 1.51.1 branch. Do you want to merge first or should I rebase my change on your branch?

@djberg96
Copy link
Owner

@Lqp1 Hm? Did I forget to git push earlier? Should be there now:

>git br
* main

>git log -n1
commit 00c69317423cc7ed1c8c9c690436d303dbb261f3 (HEAD -> main, tag: sys-filesystem-1.5.1, origin/main, origin/HEAD)
Author: Daniel Berger <[email protected]>
Date:   Sun Sep 29 22:33:30 2024 -0400

    Add changes for 1.5.1 and prep for release.

Since 305b6b7 the gem is used at runtime too.

FIXES: djberg96#74
@Lqp1
Copy link
Contributor Author

Lqp1 commented Sep 30, 2024

Yes, all good now, thanks!

I just rebased

Copy link
Owner

@djberg96 djberg96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@djberg96 djberg96 merged commit 1e02a7c into djberg96:main Sep 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing mkmf-lite gem at runtime
2 participants