Skip to content
This repository has been archived by the owner on Jan 31, 2019. It is now read-only.

Initial implementation #2

Merged
merged 58 commits into from
May 8, 2018
Merged

Initial implementation #2

merged 58 commits into from
May 8, 2018

Conversation

stefanfoulis
Copy link
Contributor

@stefanfoulis stefanfoulis commented Jul 10, 2017

Up next:

  • Hide the bucket on the confirmation page if it is not about deleting
  • Hide languages menu in Toolbar when on blog app. The languages are confusing there (they are cms page languages, not blog post languages) it was to tricky and not worth the effort right now.
  • language button dropdown is missing entries for translations that have nothing yet.
  • deploy to dem-stage.eu.aldryn.io
  • Toolbar AJAX buttons are not working yet (currently shows a confirmation screen). May need change the ajax behaviour in django-cms core. It does not seem to be respecting the url provided as a redirect from the ajax request. (Check with @czpython and @vxsx ) works. but not nicely implemented yet

Should

  • Sumbit-Row buttons in modal from frontend editing are confusing
  • aldryn-newsblog: smarter slug generation (avoid unnecessary -1 suffixes). Currently it'll change the slug every time a language is published.
  • update django-filer integration to latest version when it is done (also use the indicator dots)
  • toolbar dropdown button has wrong coloring (bug in django-cms core)
  • admin actions for publishing
  • alter admin actions for deletion to obey permissions
  • docs
  • more tests

Nice-to-have

  • A horizontal line would be good in the button dropdown menu. Is that possible @vxsx
  • I tried to add the indicator dots into the button menu, but could not figure out how to get those styles to apply there. (please help me @vxsx )

Done

Known bugs

  • exception in admin if the apps admin does not define fieldsets (not bad. Usually fieldsets is set anyway.
  • NoReverseMatch when clicking the view on site link in admin detail of blog article this is a general problem in aldryn-newsblog, if the apphook/namespace of an instance has not been published in cms yet
  • Switching language in the toolbar or url results in 404 if the Article is not available in that language. Maybe be unrelated to publisher and rather a bug in aldryn-newsblog. This happens when the cms page translation for the apphooked page was not published yet. Confusing but expected.

Todo

  • Basic model support
  • admin actions for publishing
  • alter admin actions for deletion to obey permissions
  • Integrating django-parler (with per language publication)
    • basic object copying
    • allow deleting a specific language (currently there are permission problems)
    • admin intrgration (submit row buttons should work)
    • published version read-only in admin
    • per language publishing
    • UI to delete the master object (not just a translation) (might make sense to do this as a side-effect when the last translation gets deleted)
    • better translation ui and edge cases
      • always show the delete options in the language tabs on draft and published (the x is hidden by default if there is only one language, because it is not possible to delete the last language with parler. But in our case it may just be the draft version that only has one language left and we want to be able to request deletion for that anyway. Side effect will have to be to publish or discard pending master object changes when the deletion request is published so that there is no left over master draft without any translations.)
      • fix bug where creating a draft for the second language does not work
  • Inegration with django-cms
    • Toolbar
    • Helper to copy PlaceholderField
    • Helper to copy PlaceholderField for specific languages
  • django-filer integration (optional. off by default. currently is an older version of this package vendored in) Draft/Live for Files django-cms/django-filer#993
  • basic testsuite

Annoying Edge-Cases

  • django-parler: Linking to a draft master object with a ForeignKey may show an object with less translations than actually available, because not all translations will have a draft version.

@stefanfoulis stefanfoulis self-assigned this Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants