This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Initial implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2017
53 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up next:
Hide languages menu in Toolbar when on blog app. The languages are confusing there (they are cms page languages, not blog post languages)it was to tricky and not worth the effort right now.Should
-1
suffixes). Currently it'll change the slug every time a language is published.Nice-to-have
Done
https://github.com/divio/djangocms-moderation/blob/master/djangocms_moderation/cms_toolbars.py#L75 if you put normal button as primary button and not a dropdown toggle it's going to be a split button https://github.com/divio/django-cms/blob/79425bed92869e8e64b04b3a0b10bc700392bd84/cms/templates/cms/toolbar/items/dropdown.html#L2 )
Known bugs
fieldsets
(not bad. Usuallyfieldsets
is set anyway.this is a general problem in aldryn-newsblog, if the apphook/namespace of an instance has not been published in cms yetNoReverseMatch
when clicking theview on site
link in admin detail of blog articleSwitching language in the toolbar or url results in 404 if the Article is not available in that language. Maybe be unrelated to publisher and rather a bug in aldryn-newsblog.This happens when the cms page translation for the apphooked page was not published yet. Confusing but expected.Todo
x
is hidden by default if there is only one language, because it is not possible to delete the last language with parler. But in our case it may just be the draft version that only has one language left and we want to be able to request deletion for that anyway. Side effect will have to be to publish or discard pending master object changes when the deletion request is published so that there is no left over master draft without any translations.)PlaceholderField
PlaceholderField
for specific languagesAnnoying Edge-Cases