Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash syntax error on divio project pull db #241

Closed
wants to merge 2 commits into from
Closed

Fix bash syntax error on divio project pull db #241

wants to merge 2 commits into from

Conversation

ajhalili2006
Copy link

Fixes #240

I'm currently testing this on an Ubuntu 20.04.2 Dell computer with Python 3.8 (not sure) and pip 20.x (will update later)

Andrei Jiroh Eugenio Halili added 2 commits March 3, 2021 21:40
Fixes divio#240
42f696d 
Needs to be tested locally, wait.
repo: Improve stuff in order to truly fix divio#240
ac51f6b 
Signed-off-by: Andrei Jiroh Eugenio Halili <[email protected]>
@kinkerl
Copy link
Contributor

kinkerl commented Oct 11, 2021 •
edited
Loading

Hey, thank you for your contribution!
I have a question about the change.
I think the quotes around 'db' should collide with the outer quotes ' around the SQL statement.
Could you quote the SQL with " instead?
In addition, we try to keep everything below 80 chars in line length where possible and this command can be broken down below 80 chars. Do you have a reason for making it all into one line?

Cheers

@derlin
Copy link
Member

derlin commented Aug 28, 2023

Closing due to inactivity.

@derlin derlin closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bash syntax error when attempting to check for database PID
3 participants
@ajhalili2006 @kinkerl @derlin