Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parts of lib in no_std with alloc. Tests pass #170

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hatmajster
Copy link

@hatmajster hatmajster commented Nov 5, 2023

This is ready, but not complete work, some things are still gated. I just tried to make it compile first, then for tests to pass. As it happened, here's the PR. I still have not used it in real product, and I did it blindly, so its a draft for now, though I don't expect much more work to be done here. Please verify carefully. Testing/review appreciated.
I have no idea how to split this, organize etc. Any opinions, refactor ideas appreciated. I tried to not change as much code as possible, sometimes it doesn't make any sense, sometimes looks stupid. But essentially all commits should compile in some way using no_std and alloc features.
PR requires this: Stoeoef/spade#92, so you can see this dependency in Cargo.toml for now. If it will be merged, I'll change dependency here.
As I wrote in the beginning I would like for this to not be full "no_std+alloc". Some parts are still gated. Its just a good start I hope, and if it gets merged I hope the rest may be done quickly. But I can of course add more if someone advise so. My main fear is that I just don't know if any of this actually works, so I would prefer to scope low.

…only. Main change was with alloc crate introduction. Some messiness still persists. WIP
…in alloc. Parry2d and parry3d compiles in alloc. Tests still don't.
… as much as I can go without doing anything weird
… no real prod use and many features are gated unnecessarily, but its a good start IMO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant