Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added change engine mic state and mode on caster startup for DNS #815

Merged
merged 5 commits into from
May 30, 2020

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented May 16, 2020

Description

Added setting change engine mic state and mode on caster startup defined in settings.toml

Outside of changing modes on startup switching modes set_mic_mode and set_engine_mode will not be fully implemented until exclusivity is added for all engines.

# Speech recognition engine settings
        # Speech recognition engine settings
        "engine": {
            "default_engine_mode": False, 
            "engine_mode": "normal",
            "default_mic": False, 
            "mic_mode": "on"
        },

Valid "mic_mode" settings.

	'on': mic is on # default
	'sleeping': mic from the sleeping and can be woken up by command
	'off': mic off and cannot be turned back on by voice. (DNS Only)

Valid "engine_mode" settings.

    'normal': dictation and command (Default: DNS only)
    'dictation': Dictation only 
    'command': Commands only (Default: Other engines)
    'numbers': Numbers only
    'spell': Spelling only

Related Issue

Relevant to implementing sleep/modes for other engines #797

Motivation and Context

This gives the user control over their startup experience with both the engine mode and mic. This is implemented for DNS only at the moment but in a separate PR due to the scope of testing and implementation for using grammar exclusivity.

How Has This Been Tested

This is been tested with DNS

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue or bug)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Renamed existing command phrases (we discourage this without a strong rationale).

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate functionality elsewhere in Caster.
  • I have checked for and utilized existing command phrases from within Caster (delete if not applicable).
  • My code implements all the features I wish to merge in this pull request.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests pass.

Maintainer/Reviewer Checklist

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

@LexiconCode LexiconCode added New Feature A new feature that is not currently implemented. Dragon Naturally Speaking Dragon NaturallySpeaking Engine Backend: Include version the issue. Ex. DNS 15 Caster Core Spec Issues for Caster Specs that are not part of the application or language specific grammar/ccr labels May 16, 2020
@LexiconCode LexiconCode self-assigned this May 16, 2020
@LexiconCode LexiconCode added the WIP An work in progress label May 16, 2020
@LexiconCode
Copy link
Member Author

LexiconCode commented May 16, 2020

I have a little bit of work to do with the logic in set_engine_mode.

Feel free to suggest improvements.

@LexiconCode
Copy link
Member Author

Okay this should work as expected now and I've simplified logic.

@LexiconCode LexiconCode added the Documentation Needed Issue needs grammars or function documentation label May 16, 2020
@LexiconCode LexiconCode changed the title Added change engine mic state and mode on caster startup Added change engine mic state and mode on caster startup for DNS May 22, 2020
@LexiconCode LexiconCode force-pushed the engine_manager branch 3 times, most recently from 4fd24fe to 9c991e5 Compare May 26, 2020 14:47
@LexiconCode LexiconCode removed WIP An work in progress Documentation Needed Issue needs grammars or function documentation labels May 26, 2020
 - prep for implementation for modes on other engines
@LexiconCode LexiconCode added the Complete Pull request is complete and tested as defined by Contributor label May 30, 2020
@LexiconCode LexiconCode merged commit bd1f07c into dictation-toolbox:master May 30, 2020
@LexiconCode LexiconCode deleted the engine_manager branch May 30, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caster Core Spec Issues for Caster Specs that are not part of the application or language specific grammar/ccr Complete Pull request is complete and tested as defined by Contributor Dragon Naturally Speaking Dragon NaturallySpeaking Engine Backend: Include version the issue. Ex. DNS 15 New Feature A new feature that is not currently implemented.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant