new stack for camel #497
new stack for camel #497
Conversation
|
Hi @brunoNetId. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: brunoNetId <[email protected]>
Signed-off-by: brunoNetId <[email protected]>
brunoNetId
force-pushed
the
stack-camel
branch
from
16021cf to
0288bc8
Compare
|
|
@apupier: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Hi @brunoNetId, thanks for the contribution!
Since this is a new stack, we'll need you to add an entry to CODEOWNERS, add the @devfile/che-team in the entry like this example:
Line 36 in 8dfedb7
NOTE: Omit your username for now as we'll follow the trial period for new owners, at the end of this period if you wish to continue owning the stack you can follow the process for adding yourself to the stacks CODEOWNERS entry.
|
Thanks @michael-valdron |
@brunoNetId New |
Signed-off-by: brunoNetId <[email protected]>
|
@michael-valdron I added the new entry. |
@brunoNetId Ordering in your changes is fine. |
Signed-off-by: brunoNetId <[email protected]>
|
/ok-to-test |
| @@ -0,0 +1,78 @@ | |||
| schemaVersion: 2.2.0 | |||
There was a problem hiding this comment.
You can use a newer version; at least 2.2.2
The latest version is 2.3.0, @michael-valdron do you know if we can use 2.3.0 schema version for stacks?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apupier, brunoNetId, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@svor @michael-valdron |
|
Hi @svor @michael-valdron |
There was a problem hiding this comment.
@svor @michael-valdron I see failures with odo v3, but I'm not sure if there is anything to do on my side.
Update: @brunoNetId No its a different stack causing this so nothing is needed on your side to do here.
There was a problem hiding this comment.
@brunoNetId Try a rebase to the latest changes from main now.
Description of Changes
Created a new Stack to include a new Apache Camel sample
Related Issue(s)
The following issue was created to track this PR:
devfile/api#1651
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
YES
I've run a build as per the contribution guide suggested.
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Don't think this is needed
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
I've tested the DevFile from the originating GIT repository
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
I've run the build as per the documentation in the contribution guide.
I've provisioned the devfile in the Developer Sandbox
How To Test
run the sample to provision in the Developer Sandbox.
Follow the instructions in the Readme file from:
https://github.com/RedHat-Middleware-Workshops/devsandbox-camel.git
Notes To Reviewer
I created this Sample after I was recommended to include the Stack as a contribution in this project.
The DevFile already existed in the originating GIT repo:
https://github.com/RedHat-Middleware-Workshops/devsandbox-camel.git
This repository runs various tutorials and has been improved and polished over the last 2 years
Although I've been working with devfiles for a while now, I'm not familiar with contributing Stacks/Samples in this project. Please help me to ensure I follow the steps needed.