-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure securityContext for che-gateway container #1358
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
pkg/provision/workspace/routing.go
Outdated
for i, container := range clusterRouting.Status.PodAdditions.Containers { | ||
if container.SecurityContext == nil && | ||
workspace.Config.Workspace != nil && | ||
workspace.Config.Workspace.ContainerSecurityContext != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this check
workspace.Config.Workspace != nil &&
workspace.Config.Workspace.ContainerSecurityContext != nil
to the outer if
statement on line 61 ?
Signed-off-by: Anatolii Bazko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha looks like there is a test failure
Also, wondering if we can add a test case for the SecurityContext as well?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, tolusha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For the sake of the DWO 0.32.0 release, I propose we add the test in a future PR. Currently, there doesn't seem to be any test suites that specifically tests the |
@ibuziuk the test failure was due to flakiness, after rerunning the tests, all have passed |
What does this PR do?
feat: configure securityContext for che-gateway container
What issues does this PR fix or reference?
eclipse-che/che#22747
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che