Label per-workspace PVCs with DevWorkspace ID. #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AObuchow
reviewed
Sep 7, 2023
amisevsk
force-pushed
the
label-per-workspace-pvc
branch
2 times, most recently
from
bf2870e to
870fbe2
Compare
|
/retest |
amisevsk
force-pushed
the
label-per-workspace-pvc
branch
from
870fbe2 to
555fc73
Compare
Signed-off-by: Angel Misevski <[email protected]>
amisevsk
force-pushed
the
label-per-workspace-pvc
branch
from
555fc73 to
5dc7759
Compare
AObuchow
approved these changes
Oct 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Objects owned by a single DevWorkspace should be labelled with that workspace's ID. This change adds the
controller.devfile.io/devworkspace_idto per-workspace PVCs to make it easier to find them on the cluster via label selector.What issues does this PR fix or reference?
N/A
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che