-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: temporarily pin goimports in GH Actions to v0.24.0
Part of #1314 The latest version of goimports (v0.25.0) requires go >= 1.22.0. Since we are about to do the upstream release of DWO 0.31.0, we are temporarily pinning goimports to the last working version (v0.24.0). After the 0.31.0 release of DWO, we can safely upgrade the entire repo to go 1.22.0, and use the latest version of goimports again. Signed-off-by: Andrew Obuchowicz <[email protected]>
- Loading branch information
Showing
3 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ jobs: | |
name: Run Go Tests | ||
run: | | ||
python -m pip install --upgrade pip yq | ||
go install golang.org/x/tools/cmd/goimports@latest | ||
go install golang.org/x/tools/cmd/goimports@v0.24.0 | ||
go install github.com/onsi/ginkgo/v2/[email protected] | ||
make update_devworkspace_crds test | ||
- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,7 +121,7 @@ jobs: | |
run: | | ||
# Need to grab goimports otherwise formatting after this step will fail | ||
# PR checks. | ||
go install golang.org/x/tools/cmd/goimports@latest | ||
go install golang.org/x/tools/cmd/goimports@v0.24.0 | ||
git config --global user.name "Andrew Obuchowicz" | ||
git config --global user.email "[email protected]" | ||
|