Skip to content

Commit

Permalink
fix: temporarily pin goimports in GH Actions to v0.24.0
Browse files Browse the repository at this point in the history
Part of #1314

The latest version of goimports (v0.25.0) requires go >= 1.22.0.

Since we are about to do the upstream release of DWO 0.31.0, we are
temporarily pinning goimports to the last working version (v0.24.0).

After the 0.31.0 release of DWO, we can safely upgrade the entire
repo to go 1.22.0, and use the latest version of goimports again.

Signed-off-by: Andrew Obuchowicz <[email protected]>
  • Loading branch information
AObuchow authored and dkwon17 committed Sep 10, 2024
1 parent cc0c246 commit 40d7607
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
name: Run Go Tests
run: |
python -m pip install --upgrade pip yq
go install golang.org/x/tools/cmd/goimports@latest
go install golang.org/x/tools/cmd/goimports@v0.24.0
go install github.com/onsi/ginkgo/v2/[email protected]
make update_devworkspace_crds test
-
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
name: Check format
run: |
go install github.com/google/addlicense@latest
go install golang.org/x/tools/cmd/goimports@latest
go install golang.org/x/tools/cmd/goimports@v0.24.0
if ! make check_fmt; then
echo "not well formatted sources are found:"
git --no-pager diff
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
run: |
# Need to grab goimports otherwise formatting after this step will fail
# PR checks.
go install golang.org/x/tools/cmd/goimports@latest
go install golang.org/x/tools/cmd/goimports@v0.24.0
git config --global user.name "Andrew Obuchowicz"
git config --global user.email "[email protected]"
Expand Down

0 comments on commit 40d7607

Please sign in to comment.