Switch example from using ImageNameSelector to ImageName #112
Conversation
|
/retest |
|
Is this failure something on my end that I need resolve to help get this merged (e.g. missing test)? |
Based on the your changes and the errors given I don't believe so, looking at the logs it appears to be likely change(s) in the allocated resources GitHub actions is providing: Full Log: https://github.com/devfile/devfile-web/actions/runs/8088608076 |
@thepetk @Jdubrick We'll need to open a bug to address this soon. |
Opened a bug issue: devfile/api#1464 |
Yeah I agree with @michael-valdron. I've tried also to see if there is any the code, the package.json deps or the ubuntu release here #116 but it seems we have insufficient resources from github runner. |
|
/retest |
Signed-off-by: Hunter Gerlach <[email protected]>
thepetk
force-pushed
the
docs/fix-outerloop-code-example
branch
from
1762d7c to
997d1b0
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HunterGerlach, Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looking into the broken image links reported:
- /home/runner/work/devfile-web/devfile-web/dist/cypress/apps/landing-page-e2e/scr (1280x720)
eenshots/app.cy.ts/Docs -- Version 2.0.0 -- Section Get started -- Page Quick st
art with Eclipse Che -- has valid links (failed).png
- /home/runner/work/devfile-web/devfile-web/dist/cypress/apps/landing-page-e2e/scr (1280x720)
eenshots/app.cy.ts/Docs -- Version 2.0.0 -- Section Get started -- Page Developi
ng with devfiles -- has valid links (failed).png
Some of the images in our guides may no longer exist which is why E2E check is failing.
cc: @HunterGerlach
There was a problem hiding this comment.
Looking into the broken image links reported:
- /home/runner/work/devfile-web/devfile-web/dist/cypress/apps/landing-page-e2e/scr (1280x720) eenshots/app.cy.ts/Docs -- Version 2.0.0 -- Section Get started -- Page Quick st art with Eclipse Che -- has valid links (failed).png - /home/runner/work/devfile-web/devfile-web/dist/cypress/apps/landing-page-e2e/scr (1280x720) eenshots/app.cy.ts/Docs -- Version 2.0.0 -- Section Get started -- Page Developi ng with devfiles -- has valid links (failed).pngSome of the images in our guides may no longer exist which is why E2E check is failing.
cc: @HunterGerlach
Error message might be misleading here, I think it could be, based on the guides in question, referring to the domain switch of eclipse.org to eclipse.dev and is not satisfied with the redirection response.
@HunterGerlach Fixed the links in question and opened a PR against your branch: HunterGerlach#1 |
|
Can confirm the eclipse domain change is the cause of the e2e tests failing: HunterGerlach#1 (comment) |
|
This is blocked by devfile/api#1573 |
|
devfile/api#1573 has been completed. Once this PR gets a rebase I believe the |
What does this PR do / why we need it
This PR updates the latest 2 versions (2.2.1 and 2.2.2) of the Inner/Outer loop docs to correct a regression in the example code.
ImageNameSelector->ImageNamePR acceptance criteria
Update the sidebar if there is a new file added or an existing filename is changed
How to test changes / Special notes to the reviewer
Take a look at the latest spec and confirm that the update matches the spec.