Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disk.py #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonathanSum
Copy link

@JonathanSum JonathanSum commented Jan 23, 2021

#27
after using the new import, it works.
image

deep-learning-with-pytorch#27 27
after using the new import, it works
@JonathanSum
Copy link
Author

JonathanSum commented Jan 23, 2021

I have tested it with colab notebook, and everything is good.
https://github.com/JonathanSum/pytorch-Deep-Learning_colab/blob/master/p2ch10_explore_data.ipynb

@JonathanSum
Copy link
Author

Just a note here. I got the error of this:
image

But it is solved by running this, which the positiveSample_list has length of zero. No element in the list:
from p2ch10.dsets import getCandidateInfoList, getCt, LunaDataset
candidateInfo_list = getCandidateInfoList(requireOnDisk_bool=False)
positiveInfo_list = [x for x in candidateInfo_list if x[0]]
diameter_list = [x[1] for x in positiveInfo_list]

This error is caused by myself, which is not about the code at all. That is because I forgot to run the import codes as those in above after changing the disk.py with the change of what this pull request is all about.

@JonathanSum
Copy link
Author

Things look good with running on colab:
image
I guess everything is good.

@JonathanSum
Copy link
Author

JonathanSum commented Jan 24, 2021

Note:
For the Colab notebook above in my repo, I changed it a little bit in the ch10 notebook, which is not in this pull request, so you do not need to upload the dataset. But it downloads the dataset from the dataset website and does everything. So, everyone will have 20 MB/sec to download the dataset and run it. However, I am not sure Google will like this kind of doing if a lot of people doing it in this way. Thus, I am not sure it is good in case if you use my Colab notebook in my repo.

@DanielMarchand
Copy link

This is a great patch and I've been using it thanks for figuring it out!

@renaudjmathieu
Copy link

same, thanks for the patch! tested on m1 mac

@kamal-tanwar
Copy link

Saved me a significant amount of time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants