Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check containment #685

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

jlmaurer
Copy link
Collaborator

@jlmaurer jlmaurer commented Sep 13, 2024

Description

Attempts to fix #684

Motivation and Context

If the global bounding box is larger than the world box [-90, 90, -180, 180], then the current code gets unhappy (see #684). This checks whether the world box fits inside the requested box and sets the requested box to equal the world.

How Has This Been Tested?

  • added unit tests to check the basic functionality
  • Made a bunch of formatting tweaks to fix ruff issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] checkContainment fails on global zenith HRES
1 participant