CB-3753-1809-fr-add-field-hints-in-the-filter-field #3151
+501
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
requested review from
Wroud,
devnaumov and
SychevAndrey
and removed request for
Wroud and
devnaumov
SychevAndrey
approved these changes
Dec 26, 2024
| interface InputAutocompleteOptions { | ||
| sourceHints: InputAutocompleteProposal[]; | ||
| matchStrategy?: InputAutocompleteStrategy; | ||
| filter?: (suggestion: InputAutocompleteProposal, lastWord?: string) => boolean; |
There was a problem hiding this comment.
I believe predicate is more descriptive word for that prop, then filter.
Comment on lines
+50
to
+52
| const words = this.input?.split(' '); | ||
|
|
||
| if (!isNotNullDefined(words) || !isNotNullDefined(cursorPosition) || !isNotNullDefined(this.currentWord)) { |
There was a problem hiding this comment.
Do we need to check words and cursor here if currentWord getter should return falsy value if there is no words or cursorPosition?
Comment on lines
+101
to
+107
| (this.matchStrategy === 'startsWith' && | ||
| values.some(value => isNotNullDefined(this.currentWord) && value.startsWith(this.currentWord))) || | ||
| (this.matchStrategy === 'contains' && values.some(value => isNotNullDefined(this.currentWord) && value.includes(this.currentWord))) || | ||
| (this.matchStrategy === 'fuzzy' && | ||
| values.some(value => isNotNullDefined(this.currentWord) && isFuzzySearchable(this.currentWord, value))) | ||
| ); | ||
| }) |
There was a problem hiding this comment.
Suggested change
| (this.matchStrategy === 'startsWith' && | |
| values.some(value => isNotNullDefined(this.currentWord) && value.startsWith(this.currentWord))) || | |
| (this.matchStrategy === 'contains' && values.some(value => isNotNullDefined(this.currentWord) && value.includes(this.currentWord))) || | |
| (this.matchStrategy === 'fuzzy' && | |
| values.some(value => isNotNullDefined(this.currentWord) && isFuzzySearchable(this.currentWord, value))) | |
| ); | |
| }) | |
| const isMatch = () => { | |
| const { matchStrategy, currentWord } = this; | |
| if (!isNotNullDefined(currentWord)) { | |
| return false; | |
| } | |
| const matchFunctions: { [key: InputAutocompleteStrategy]: (value: string) => boolean } = { | |
| startsWith: value => value.startsWith(currentWord), | |
| contains: value => value.includes(currentWord), | |
| fuzzy: value => isFuzzySearchable(currentWord, value), | |
| }; | |
| return values.some(matchFunctions[matchStrategy]); | |
| }; |
Maybe like that? And we checked thus.currentWord just above, so maybe we can skip this check:
if (!isNotNullDefined(currentWord)) {
return false;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.