Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

ci: update workflows #862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: update workflows #862

wants to merge 2 commits into from

Conversation

eyarz
Copy link
Member

@eyarz eyarz commented Dec 22, 2022

No description provided.

@eyarz eyarz requested a review from a team December 22, 2022 14:44
Copy link

@Rahul-Prasad-07 Rahul-Prasad-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @eyarz ,

In cron_checks.yml ,

-- you can add --

dead_readme_links:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
ref: main
submodules: 'recursive'

-> This change will ensure that the correct branch (the "main" branch) and all of its submodules are checked out in the workflow. This is important to ensure that the correct code is used for subsequent steps in the workflow, such as checking for dead links in the Markdown files.

Copy link

@Rahul-Prasad-07 Rahul-Prasad-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cron_checks.yml ,

To improve the performance, reliability, and compatibility of the actions used in the workflow,
you can do these changes in this yaml file,

  • The version of the actions/stale action has been upgraded from v6 to v8.
  • The version of the actions/checkout action has been upgraded from v3 to v2.
  • The version of the lycheeverse/lychee-action action has been upgraded from v1.3.2 to v1.5.0.
  • The version of the peter-evans/create-issue-from-file action has been upgraded to peter-evans/create-issue@v2.

Let me know what's your view on this .

@eyarz
Copy link
Member Author

eyarz commented Feb 12, 2023

@Rahul-Prasad-07 thank you for the review.
submodules are not part of the (main) code, so I don't think dead links should be checked here.
instead, the origin of the submodule should check for dead links.

regarding the version updates:
actions/stale - the latest version is v7, not v8
actions/checkout - v3 is newer than v2
lycheeverse/lychee-action - I don't see any reason to update
peter-evans/create-issue-from-file action - v3 is newer than v2

@Rahul-Prasad-07
Copy link

@Rahul-Prasad-07 thank you for the review. submodules are not part of the (main) code, so I don't think dead links should be checked here. instead, the origin of the submodule should check for dead links.

regarding the version updates: actions/stale - the latest version is v7, not v8 actions/checkout - v3 is newer than v2 lycheeverse/lychee-action - I don't see any reason to update peter-evans/create-issue-from-file action - v3 is newer than v2

Got it 👍

Copy link

@adilwahla adilwahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can anyone tell me docx of datree are working or not?

@shalev007
Copy link
Contributor

@adilwahla
Datree as a business no longer operates, therefore the docs are no longer maintained.
You can still check them out via wayback machine https://web.archive.org/web/20230808014035/https://hub.datree.io/
@eyarz

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants