feat: support RBAC bypass by group for OKD resources with requester annotation #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto staging_tests # Conflicts: # pkg/k8sMetadataUtil/k8sMetadataUtil.go
royhadad
commented
Jul 6, 2023
internal/startup/startup.go
Outdated
| @@ -43,6 +44,7 @@ func Start() { | |||
| basicCliClient := clients.NewCliServiceClient(deploymentConfig.URL, basicNetworkValidator, state) | |||
| errorReporter := errorReporter.NewErrorReporter(basicCliClient, state) | |||
| internalLogger := logger.New("", errorReporter) | |||
| openshiftClientInstance, err := openshiftClient.NewOpenshiftClient() | |||
There was a problem hiding this comment.
TODO handle this error somehow
shmu3l
reviewed
Jul 9, 2023
| func (oc *OpenshiftService) getGroupsWithCache() (*userClientV1Api.GroupList, error) { | ||
| valueFromCache, found := oc.cache.Get(groupsCacheKey) | ||
| if found { | ||
| return valueFromCache.(*userClientV1Api.GroupList), nil |
There was a problem hiding this comment.
syntax question, valueFromCache.(*userClientV1Api.GroupList) . the dot in the middle meaning that valueFromCache access the type of (*userClientV1Api.GroupList) ?
myishay
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.