fix: convert to comma separated string

datreeio · Jul 11, 2023 · d408dbb · d408dbb
1 parent 5fe1a6a
commit d408dbb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/charts/datree-admission-webhook/templates/deployment.yaml b/charts/datree-admission-webhook/templates/deployment.yaml
@@ -72,8 +72,10 @@ spec:
               valueFrom:
                 fieldRef:
                   fieldPath: metadata.name
+            {{- with .Values.datree.enabledWarnings }}
             - name: DATREE_ENABLED_WARNINGS
-              value: "{{.Values.datree.enabledWarnings}}"
+              value: '{{ join "," . }}'
+            {{- end }}
           {{- with .Values.securityContext }}
           securityContext: {{ toYaml . | nindent 12 }}
           {{- end }}

diff --git a/pkg/serviceState/serviceState.go b/pkg/serviceState/serviceState.go
@@ -134,11 +134,9 @@ type EnabledWarnings struct {
 
 func (s *ServiceState) GetEnabledWarnings() EnabledWarnings {
 	// Environment variables are plain strings and not arrays, so we need to parse the string to get the enabled warnings
-	// input example [failedPolicyCheck RBACBypassed skippedBySkipList]
+	// input example failedPolicyChec,RBACBypassed,skippedBySkipList
 	enabledWarningsStr := s.enabledWarnings
-	enabledWarningsStr = strings.ReplaceAll(enabledWarningsStr, "[", "")
-	enabledWarningsStr = strings.ReplaceAll(enabledWarningsStr, "]", "")
-	enabledWarningsStrList := strings.Split(enabledWarningsStr, " ")
+	enabledWarningsStrList := strings.Split(enabledWarningsStr, ",")
 	enabledWarningsTypes := []string{"passedPolicyCheck", "failedPolicyCheck", "RBACBypassed", "skippedBySkipList"}
 	enabledWarnings := EnabledWarnings{}