Skip to content

Commit

Permalink
feat: skip validation of helm release information
Browse files Browse the repository at this point in the history
  • Loading branch information
Niv Weiss committed Jul 20, 2023
1 parent 9c90d61 commit 4d9eeae
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions pkg/services/resourcesFilterService.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func ShouldResourceBeValidated(admissionReviewReq *admission.AdmissionReview, ro
}

resourceKind := admissionReviewReq.Request.Kind.Kind
resourceName := rootObject.Metadata.Name
managedFields := rootObject.Metadata.ManagedFields
userInfo := admissionReviewReq.Request.UserInfo
resourceAnnotations := rootObject.Metadata.Annotations
Expand Down Expand Up @@ -71,6 +72,12 @@ func ShouldResourceBeValidated(admissionReviewReq *admission.AdmissionReview, ro
}
}

if isHelmReleaseInfo(resourceKind, resourceName) {
return ShouldValidatedResourceData{
ShouldValidate: false,
}
}

if strings.HasPrefix(userInfo.Username, "system:serviceaccount:openshift") {
if isRequesterExist, openShiftRequester := isOpenshiftRequesterExists(resourceAnnotations); isRequesterExist {
return ShouldValidatedResourceData{
Expand Down Expand Up @@ -137,6 +144,15 @@ func isNamespaceThatShouldBeSkipped(admissionReviewReq *admission.AdmissionRevie
return slices.Contains(namespacesToSkip, admissionReviewReq.Request.Namespace)
}

func isHelmReleaseInfo(resourceKind string, resourceName string) bool {
if strings.HasPrefix(resourceKind, "Secret") {
if strings.Contains(resourceName, "sh.helm.release.v1.") {
return true
}
}
return false
}

func isObjectAndOldObjectEqual(admissionReviewReq *admission.AdmissionReview) bool {
if admissionReviewReq.Request.OldObject.Raw == nil {
return false
Expand Down

0 comments on commit 4d9eeae

Please sign in to comment.