PYTHON-539 Timeouts in ResponseFuture should notify the conviction policy #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when calling Cluster.signal_connection_failure (which we do in the unit test).
|
AppVeyor failure is from a few random test failures, which (unfortunately) happens from time to time with those builds. I believe the Jenkins failures stem from an issue with the Jenkins server in question; this needs some more work. |
|
After looking into this today I've determined that the Jenkins failures do represent legit breakage with this PR. Can't tell yet if it's an unintended consequence of these changes or if the tests are making too many assumptions... still working on sorting that out. |
|
Test failures are also occurring on master; we've definitely got an issue to sort out there. I've filed PYTHON-1304 to address those issues (and possibly to get us back to a clean build on Jenkins generally). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.