Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker]Ensure namespace deletion doesn't fail #259

Merged
merged 3 commits into from
May 2, 2024

Conversation

eolivelli
Copy link
Collaborator

@eolivelli eolivelli commented May 1, 2024

Problem

Deleting a namespace sometimes fails and leaves znodes around, especially the "bundle owner" nodes /namespace/NAMESPACE/xxxxxx

Modifications

  • ensure that all the children of /namespace/NAMESPACE are deleted, especially the ephemeral nodes for ownership
  • ensure that on the code path that handles the deletion of the namespace we make progress, the main fact is about not relying on "cache.exists" before using a "delete": the new code is more pessimistic that goes with "deleteIfExists", handling "NotFound" gracefully
  • add more logs about the delete namespace execution path

With this patch

  • delete namespace seems to consistently work
  • there are no more spammy logs about errors around the topic policies event reader (changelog_events...)
  • in case we see an error we log at which point the procedure was (because we log all the paths that are deleted from zk)

@eolivelli eolivelli changed the title Ensure namespace deletion doesn't fail [improve][broker]Ensure namespace deletion doesn't fail May 1, 2024
…sources/BaseResources.java

Co-authored-by: Andrey Yegorov <[email protected]>
@eolivelli eolivelli merged commit 5bf373d into 3.1_ds May 2, 2024
3 checks passed
@eolivelli eolivelli deleted the fix/namespace-deletion-luna branch May 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants