Prevent race condition while deleting namespace #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds much debug during namespace deletion.
There is a fix for a potential race condition in which:
Under this condition the broker tries to delete the /namespace/tenant/namespace and it fails, reporting a misleading error about topics created during the deletion.
I have reproduced the case manually a few times but I don't have a way of consistently reproducing the problem, currently I need 6 brokers with 3 zookeeper nodes.
The fact that I need such system makes me suspect of some problem in the local cache about bundle ownership, that goes out of sync: maybe because the local broker is connected to another zookeeper server in respect to the old "owner" that released the ephemeral node while unloading the bundle?