Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx KAAP Issues #181

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

rithick-ctds
Copy link

  • Fix NPE when authentication is false.
  • Remove ensemblePlacementPolicy if it's null as it causes ClassNotFound exception in autorecovery pods.
  • Remove label assignments from volumeClaimTemplate in StatefulSet to prevent failures patching statefulset.

Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you fix the tests?

Copy link
Collaborator

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions about removing labels and the side-effects of this decision.
Maybe @pgier has better understanding of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants