Fix tls ports for FunctionWorkers and Zookeeper #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -299,7 +299,7 @@ public void patchConfigMap() { | |||
| "pulsarRootDir", "/pulsar", | |||
| "submittingInsidePod", true, | |||
| "pulsarServiceUrl", brokerServiceUrl, | |||
| "pulsarAdminUrl", "https://%s.%s:6750/" | |||
| "pulsarAdminUrl", "https://%s.%s:6751/" | |||
There was a problem hiding this comment.
Given that line 301 has brokerServiceUrl, I think we might need to dynamically compute this value.
There was a problem hiding this comment.
It seems to me that are a lot of little things to do in this class like making use of constants for the ports provided as ints at the top, but likely better as strings.
There was a problem hiding this comment.
Yes it has to be computed based on tls configuration
|
Some tests are broken. |
nicoloboschi
suggested changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haxx tests discovered issues running function workers with the kaap operator and also some issues have started to appear with running pulsar 3.0 and master tests using the kaap operator and tls.
This is a naive attempt to fix the issue, but it is not tested.