CPP-956 Fix gcc compiler warnings for integration tests #527
Conversation
| Cluster& with_hostname_resolution(bool enable = true) { | ||
| EXPECT_EQ(CASS_OK, cass_cluster_set_use_hostname_resolution( | ||
| get(), (enable == true ? cass_true : cass_false))); | ||
| return *this; | ||
| } | ||
| #if defined(__GNUC__) || defined(__INTEL_COMPILER) | ||
| # pragma GCC diagnostic pop | ||
| #endif |
There was a problem hiding this comment.
We might be able to do away with this function all together. It's only used in some of the DSE tests and those tests appear to pass without them, at least against DSE 6.7.7. The code above seems less intrusive than potentially changing how a test behaves so I decided to start with this... but I could be convinced otherwise.
|
"make" after "cmake -DCASS_BUILD_INTEGRATION_TESTS=On .." completes with no warnings after this change |
| @@ -148,6 +148,10 @@ void Integration::SetUp() { | |||
| data_center_nodes.push_back(number_dc2_nodes_); | |||
|
|
|||
| if (is_ccm_requested_) { | |||
| #if defined(__GNUC__) || defined(__INTEL_COMPILER) | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Wcatch-value" | |||
There was a problem hiding this comment.
Can the code just be fixed to resolve the warning? I think CCM::BridgeException be --> CCM::BridgeException& be will fix.
| */ | ||
| #if defined(__GNUC__) || defined(__INTEL_COMPILER) | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wdeprecated-declarations" |
There was a problem hiding this comment.
I think it's fine to have deprecation warnings.
There was a problem hiding this comment.
I don't think we should be using pragma's for this...It's kind of dangerous.
- The first warning is valid and should be fixed.
- The other two are for our deprecated functions, the fix is to eventually remove those functions and we should see those warnings until they're removed.
No description provided.