Allow custom SAI components discovery #1338
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the code that "discover" which SAI components files an SSTable has to allow making that code customizable. The default behavior remains the existing one, that is the TOC file is consulted, with a fallback to scanning disk if the TOC file is missing or corrupted. The way to customize this behavior is similar to what `SSTableWatcher` does: a new system property, `-Dcassandra.sai.custom_components_discovery_class` allows to load a specific class (that extends the `IndexCoomponentDiscovery` class) instead of the default. As part of the refactor to make this new customisability easier, this introduces a new `ComponentsBuildId` class that is the pair of the version and generation of a group of components, since this is what ultimately defines a given component "group" build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code that "discover" which SAI components files an SSTable has to allow making that code customizable. The default behavior remains the existing one, that is the TOC file is consulted, with a fallback to scanning disk if the TOC file is missing or corrupted.
The way to customize this behavior is similar to what
SSTableWatcherdoes: a new system property,-Dcassandra.sai.custom_components_discovery_classallows to load a specific class (that extends theIndexCoomponentDiscoveryclass) instead of the default.As part of the refactor to make this new customisability easier, this introduces a new
ComponentsBuildIdclass that is the pair of the version and generation of a group of components, since this is whatultimately defines a given component "group" build.This is a WIP in the context of https://github.com/riptano/cndb/issues/10889.