Just reuse constants for assertions

datastax · Sep 19, 2024 · 310929b · 310929b
1 parent 956cb9a
commit 310929b
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/src/test/java/com/datastax/cdm/cql/codec/ASCII_BLOBCodecTest.java b/src/test/java/com/datastax/cdm/cql/codec/ASCII_BLOBCodecTest.java
@@ -25,6 +25,7 @@
 import com.datastax.oss.driver.api.core.ProtocolVersion;
 
 public class ASCII_BLOBCodecTest {
+    private final String INPUT = "Encode this Text string to Blob";
 
     private ASCII_BLOBCodec codec;
 
@@ -35,11 +36,10 @@ public void setup() {
 
     @Test
     public void encodeDecode() {
-        ByteBuffer buffer = codec.encode(ByteBuffer.wrap("Encode this Text string to Blob".getBytes()),
-                ProtocolVersion.V4);
+        ByteBuffer buffer = codec.encode(ByteBuffer.wrap(INPUT.getBytes()), ProtocolVersion.V4);
         ByteBuffer retBuffer = codec.decode(buffer, ProtocolVersion.V4);
-        assertEquals("'Encode this Text string to Blob'", codec.format(retBuffer));
-        assertEquals(retBuffer, codec.parse("Encode this Text string to Blob"));
+        assertEquals("'" + INPUT + "'", codec.format(retBuffer));
+        assertEquals(retBuffer, codec.parse(INPUT));
     }
 
 }
diff --git a/src/test/java/com/datastax/cdm/cql/codec/BLOB_ASCIICodecTest.java b/src/test/java/com/datastax/cdm/cql/codec/BLOB_ASCIICodecTest.java
@@ -15,7 +15,6 @@
  */
 package com.datastax.cdm.cql.codec;
 
-import static com.datastax.oss.protocol.internal.ProtocolConstants.Version.V4;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.nio.ByteBuffer;
@@ -26,6 +25,7 @@
 import com.datastax.oss.driver.api.core.ProtocolVersion;
 
 public class BLOB_ASCIICodecTest {
+    private final String INPUT = "Encode this Text string to Blob";
 
     private BLOB_ASCIICodec codec;
 
@@ -36,9 +36,9 @@ public void setup() {
 
     @Test
     public void testEncode() {
-        ByteBuffer buffer = codec.encode("Encode this Text string to Blob", ProtocolVersion.V4);
+        ByteBuffer buffer = codec.encode(INPUT, ProtocolVersion.V4);
         String retBuffer = codec.decode(buffer, ProtocolVersion.V4);
-        assertEquals("Encode this Text string to Blob", retBuffer);
+        assertEquals(INPUT, retBuffer);
     }
 
 }
diff --git a/src/test/java/com/datastax/cdm/cql/codec/BLOB_TextCodecTest.java b/src/test/java/com/datastax/cdm/cql/codec/BLOB_TextCodecTest.java
@@ -15,7 +15,6 @@
  */
 package com.datastax.cdm.cql.codec;
 
-import static com.datastax.oss.protocol.internal.ProtocolConstants.Version.V4;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.nio.ByteBuffer;
@@ -26,6 +25,7 @@
 import com.datastax.oss.driver.api.core.ProtocolVersion;
 
 public class BLOB_TextCodecTest {
+    private final String INPUT = "Encode this Text string to Blob";
 
     private BLOB_TEXTCodec codec;
 
@@ -36,9 +36,9 @@ public void setup() {
 
     @Test
     public void testEncode() {
-        ByteBuffer buffer = codec.encode("Encode this Text string to Blob", ProtocolVersion.V4);
+        ByteBuffer buffer = codec.encode(INPUT, ProtocolVersion.V4);
         String retBuffer = codec.decode(buffer, ProtocolVersion.V4);
-        assertEquals("Encode this Text string to Blob", retBuffer);
+        assertEquals(INPUT, retBuffer);
     }
 
 }
diff --git a/src/test/java/com/datastax/cdm/cql/codec/TEXT_BLOBCodecTest.java b/src/test/java/com/datastax/cdm/cql/codec/TEXT_BLOBCodecTest.java
@@ -25,6 +25,7 @@
 import com.datastax.oss.driver.api.core.ProtocolVersion;
 
 public class TEXT_BLOBCodecTest {
+    private final String INPUT = "Encode this Text string to Blob";
 
     private TEXT_BLOBCodec codec;
 
@@ -35,11 +36,10 @@ public void setup() {
 
     @Test
     public void encodeDecode() {
-        ByteBuffer buffer = codec.encode(ByteBuffer.wrap("Encode this Text string to Blob".getBytes()),
-                ProtocolVersion.V4);
+        ByteBuffer buffer = codec.encode(ByteBuffer.wrap(INPUT.getBytes()), ProtocolVersion.V4);
         ByteBuffer retBuffer = codec.decode(buffer, ProtocolVersion.V4);
-        assertEquals("'Encode this Text string to Blob'", codec.format(retBuffer));
-        assertEquals(retBuffer, codec.parse("Encode this Text string to Blob"));
+        assertEquals("'" + INPUT + "'", codec.format(retBuffer));
+        assertEquals(retBuffer, codec.parse(INPUT));
     }
 
 }